geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...
Date Mon, 12 Jun 2017 19:05:41 GMT
Github user YehEmily commented on a diff in the pull request:

    https://github.com/apache/geode/pull/571#discussion_r121499647
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/logging/LogWriterFactory.java
---
    @@ -87,19 +87,19 @@ public static InternalLogWriter createLogWriterLogger(final boolean
isLoner,
             // LOG:CONFIG:
             logger.info(LogMarker.CONFIG, Banner.getString(null));
           }
    +      System.setProperty(InternalLocator.INHIBIT_DM_BANNER, "true"); // Ensure no more
banners will
    --- End diff --
    
    Yes, I had a suspicion that this would be an issue - do you have any suggestions concerning
how to do this without changing a system property? I was considering just checking the log
for whether it contains the banner, but this seems inefficient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message