geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pivotal-jbarrett <...@git.apache.org>
Subject [GitHub] geode-native pull request #102: GEODE-2741: Adding a warning for 64bit Windo...
Date Sat, 10 Jun 2017 03:13:35 GMT
Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/102#discussion_r121248442
  
    --- Diff: src/CMakeLists.txt ---
    @@ -17,6 +17,15 @@ project(nativeclient)
     
     list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/../cmake)
     
    +if(CMAKE_GENERATOR MATCHES Win64*)
    +  if ((CMAKE_GENERATOR MATCHES "Visual Studio") AND (CMAKE_GENERATOR_TOOLSET STREQUAL
""))
    --- End diff --
    
    Why not just set the `CMAKE_GENERATOR_TOOLSET`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message