geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kirklund <...@git.apache.org>
Subject [GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...
Date Fri, 09 Jun 2017 18:07:45 GMT
Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/571#discussion_r121188448
  
    --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
---
    @@ -478,9 +478,8 @@ private InternalLocator(int port, File logF, File stateF, InternalLogWriter
logW
         if (logWriter == null) {
           logWriter = LogWriterFactory.createLogWriterLogger(false, false, this.config,
               !startDistributedSystem);
    -      if (logger.isDebugEnabled()) {
    +      if (logger.isDebugEnabled())
    --- End diff --
    
    We've always had {'s in our style guidelines. So most of us are adding them in for small
if-blocks rather than removing them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message