geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 59946: GEODE-3054: escaping the escape character in the command string before passing it to the SimpleParser
Date Fri, 09 Jun 2017 16:34:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59946/#review177495
-----------------------------------------------------------


Ship it!




Ship It!

- Jared Stewart


On June 9, 2017, 2:57 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59946/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 2:57 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3054: escaping the escape character in the command string before passing it to
the SimpleParser
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java df16e9b9e9f71f21ef7c8ac84267a9858ee4298c

>   geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueAdapter.java
5c466a0c70c433d5f595cf3eab903fda8d362f9c 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueConverter.java
e3e1fec243fcb2e4048c60510af52c799e9c5110 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java
ab6dc3d10a6235af0ca6fc5164cac5d3c2419cdd 
> 
> 
> Diff: https://reviews.apache.org/r/59946/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin successfull
> hydra test failures related to path name are fixed.
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message