geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kirk.l...@gmail.com>
Subject Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance
Date Tue, 06 Jun 2017 22:37:51 GMT


> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Lines 79 (patched)
> > <https://reviews.apache.org/r/59852/diff/2/?file=1743276#file1743276line83>
> >
> >     this seems like a good utility method to find the security service if it's not
passed down in the method or in the member variable. Should we make it public and put it in
say: GemfireCacheImpl.findSecurityService()?

Maybe SecurityService.findSecurityService(). I want to avoid adding more stuff (especially
static methods) to GemFireCacheImpl.


- Kirk


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
-----------------------------------------------------------


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick
Rhomberg.
> 
> 
> Bugs: GEODE-2632
>     https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark ClientCachePutBench. I
increased the runtime of ClientCachePutBench from 30 minutes to 2 hours to get more accurate
measurement. I'll update the "Testing Done" section with performance numbers when that finishes
running. My measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService implementation(s) immutable
to improve performance of client/server as measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could leave out
the bulk of client Command classes and tests -- let me know if this review is too big and
unwieldy.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 38fdac692315153cda9b4956d0fbbf66fa8f6399

>   geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 0d678ca4d08d100ac99266c5d550d9cee7a13ea3

>   geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
029e6377f56d80dd81e4cec430f106ac743e5178 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
60249663aad0a59f1d292d0c5336cac33e503204 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 670c697c7f6c3d22a3c79d10be4e9c9929cd612b

>   geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 5e352241ac114b891adb178e1820e8c74017fa64

>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869

>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0

>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
9658f98da808e50b87fe54854df249b28b97662d 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
1fb8c8cac62c54b582d40688a423fddcae23b36e 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
adf702a1d361ba28f4ebe46695325d23344db756 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
8450db905a3834374bd451b55d8720d313d21d2a 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
485ccae143f9897a52e57cf82b1386e709d9e22c 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
3feba0d22986600d8f10c84d6e072f790bb4c74f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
ab199542469ae7c578ef9612d6d789f3d58f8023 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
cf9c470e79d6a8aaf636de5983abb207250efa12 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseConnection.java
21f0cad2055abbf8ca811b36b4d7855cde16a3d3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CommitCommand.java
366d77c4065c197e39a5d949a7f09460d644f14e 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java
9cb2528d7b49f184b746c324fa8b9888582a5e2f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java
b2ce0555ee458c6a3ab6d1b485883e0226beacf7 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java
0dec596d1ae8504241ae8c3070a070d247bd8762 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Default.java
3daaec5cbf44d312971187eaa87427364ac5bd04 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java
83ab394c5b43063b989f74762659cff399d8846b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java
3aebbb517de955aa650a6c843237817e976f6f8e 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java
886994e332f16848c7327c02343f04d97f74a757 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction.java
c146d27cbbc0c1180e93d43e60c12cd3321f1494 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65.java
23d5b1820aa99d94ca13d4a747f1686477edad29 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66.java
46302bc8e4c74f3f32e1916494d4c51808117b3d 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction70.java
09fe20e72231b7b60201d50917e0a777392ef476 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction.java
82a378dacc171d6989c95b3a4ff31e7d9abddeca 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction61.java
12919d0455595839965d20f1763df807055fb818 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction65.java
3be907b6a899f5ebc5dd5a680fe146be64261d58 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction66.java
674082c2392ebdbdeb4ed3b445e3886532b650b3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunctionSingleHop.java
cf961371f8ddde4bc68479ea7983b5e8a2351886 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GatewayReceiverCommand.java
d489b8859b34b7f0174ac76bc394707e42482885 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java
2ca8804008ac2034cb29b05c47bb7f259a3229b2 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll.java
01c5c9cc55ccff4a0efecb644c0fe36e0f5a4626 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651.java
ad8ef49bf16d7f7492f96cb5c7f39f6498a8e6c4 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70.java
267a5b2013f19932a3f6811b39442ca51ec10e14 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallback.java
db97d53ff75e418323e1bc7f32976ddabdfeda89 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPRMetadataCommand.java
201b5c04451a1f1f2136956d5e80d47acaeb06dc 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPRMetadataCommand66.java
7b370fe3bb5661665519551fef50d7a3a0007ee2 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommand.java
6be9353834baf31198b45bdb6bb8fbeaeca83d54 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommand66.java
251f4dabc32f3f118b305e7555e9a45297e9c565 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetFunctionAttribute.java
2c1f26c08e1a304b83de0c481b425e5c0e6cb392 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXEnumById.java
15215de643fda68c727b12608028da0434f1c9b7 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXIdForEnum.java
40c62a710291d285d4cdf2629c9e1882e768081b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXIdForType.java
c1de0fc7fde2c9693abc5c1aa9742abaa3aef223 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXTypeById.java
16e9dd08d64bb922fb7a509044c410db12b34a10 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPdxEnums70.java
7753584ce4fdd845f64ee956f7cc0cad95acb7fe 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPdxTypes70.java
c31a3751e9fb6b4b6b15ea62027c81078584dc91 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalid.java
040e1c28cb69dda3fc0f2f904baba3e31d580b41 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java
801b3ad51ce0dc4ba497a81deeef2857b8ac291c 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java
66de34791ed369c43580c8d8e6f0ce5838564a1c 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MakePrimary.java
ac9901ce0d0bd066efead38719d0120730f48960 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ManagementCommand.java
9a795406e86dee19e544a603dd31386efad2b1ea 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PeriodicAck.java
121ec37f3d361fc6a0dcd79642edacb0f0faf32b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Ping.java
adcfd1499dddf5d50458f95efd501d3038f496d3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java
76c8184a95c5c1e76b87edddeb9e74e69dab72fb 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put61.java
6f1583a50273d6a2f9589c169d364ad640efefea 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put65.java
a07837281b7517163f3fc82dfaa5e57ba2b65f46 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll.java
ba8b1458072f0667de5564ceac486772b3dac8b6 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll70.java
fb2bdb8c68f8e3a266582f73c3f1831a9f92bede 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll80.java
c6c26f70d34919e1639f482e41e6257d3f052cde 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutUserCredentials.java
ea5c8750418a7c21a55976f03fcc43e8db164a1f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java
b7d28107f8e26677491635194263919862b3ddd8 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java
e52fa3f06b80c39bc43bc96c782c683760af7b6a 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterDataSerializers.java
053b2a8fc0918f4bf9139a1fc862964344965104 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInstantiators.java
df5a46c0201123b9b6d70ea4d8a597a7e1825fa6 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest.java
edd917a9f92aa0e79bba60c76df12512d8c7373f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61.java
bad3bedaa070ba4fb1232bc3909dff4a9c531d41 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList.java
5f5fafa6e89ccb855cb8a9611f9bf8f2d4b1003e 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61.java
40a3c25709a01febd256b712db9d8580d9e8f121 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java
6a2ad95e6dab429de332744db2906db104236096 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAll.java
a295c54386c8ffa565577004dd2616ed99b480b3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveUserAuth.java
cc42e0d495c39578f7b0f0a83fcfe1474ab63156 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java
6f97d313c490a15417b144ac50899e1d5491a0fe 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RequestEventValue.java
a6d65784bb6cb31b373e8edbcf30dd8d95f68857 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RollbackCommand.java
cd12ea78b422aec4f4c5995d99a285245847a508 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java
c4515abb4da1629b524896d0fc27efadaca73319 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommand.java
9fc3fd153e1d6cab2259c1f99fd5a20ec12041e4 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
03270d647e03def8f432967258a15248ae565e4a 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterest.java
199ac18c9f5d0293a18976ea0d88054a80fe1df3 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestList.java
1968bff1b86633db92daa196d8fcd4acec81041d 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UpdateClientNotification.java
2f434fb60e4440229e11509a1e31bbdca49599a9 
>   geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
f99f9dbbf2126e53327a9bf5b569ea2f0ab6e537 
>   geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
f9fade1cfe8c181b0a0874869a66643c00300f98 
>   geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java 14784c391212095413c0d577cfc65de7247080b5

>   geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitialization.java
PRE-CREATION 
>   geode-core/src/main/java/org/apache/geode/internal/security/shiro/JMXShiroAuthenticator.java
2a641d303df5f74bfa5a9fabce7894da844415cd 
>   geode-core/src/main/java/org/apache/geode/management/cli/CommandService.java 767cf94dd53b2b4b3a609bafa90c52ec97508182

>   geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
3e6e44846ce297f387d56e2df999b2a9d101b427 
>   geode-core/src/main/java/org/apache/geode/management/internal/SystemManagementService.java
fc8eb9759edc50e512c82c423cd18a0c2d4318b1 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
ad40518f8a6e4e57a0abd8994d7cd9ad1db5d3d0 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
cb9c4fe50c8f45f6a948fd0802cb91b69d45954d 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
30d840a0feac62ed0efae66692e06de0387d3082 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshCommand.java
d46024d386209e9161658c1f2422f3be6ad7d49e 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
b3d96757b327b6658ff2eb84233a0e30e797a646 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
e2164a3750a8364b379181df62e5b56fbd13a2df 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java
c2c6e1425d71af9d2ea59046b17afd70ad30dd68 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/MemberCommandService.java
a19c5cbe3ba52e0e736f6f22ab50fc3f29d9f44a 
>   geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RecreateCacheFunction.java
a00a79e6bc2f15ab67adbff4eff142505e07885d 
>   geode-core/src/main/java/org/apache/geode/management/internal/security/AccessControlMBean.java
6514a33e52611994ddc16a58414146ebaad75c65 
>   geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java
fe79efbed0aa7ec9a3d27526df2f4a86794513c2 
>   geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/AbstractCommandsController.java
54c29f852bee7281662844fd061e462de1832e6d 
>   geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
56d9b9e0344eea5db42c57d9e199ac49011e5cd1 
>   geode-core/src/main/java/org/apache/geode/security/PostProcessor.java 707e3cf8e114a9d52d0bfb59b3b8b931fc6aaefe

>   geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
dc73f04309d36fec79558914a81f5eddcbbbe5a9 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java
f112d1a20091adc1a93a28bca63c48ddcd6bf902 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/AbstractGMSAuthenticatorTestCase.java
f17b40bbda9d9b3de8f842fc54b0ed7e521bc892 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithAuthenticatorTest.java
b9f6429ad6b1ee324175d5f9e101de7e835c2b65 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticatorWithSecurityManagerTest.java
0cb69943c08142ac609e7a2d400bc60aaaf5a3f7 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java
423d7e10e19e65d21d0788d52de63ee273ffff31 
>   geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionJUnitTest.java
d0f57938afca5e311ced743fa3f71a7bcc2a9393 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
153e77b3d4c115aae81dc8722992b5d7262d414a 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java
3a6c2a36189229ec535b7025738fad5db538bb50 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKeyTest.java
bc1be3e8d6a28b36c011b074d2c3eb1c71536c5c 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java
c946e8af6d525deab11d41952b840972167d8e3a 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java
d3f68f20095ca3b4b003f5b7d692267f80c6205b 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java
4abdebf88e80439c2437f552b2b5078469d77f52 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java
24105a6e5b11a9f8e65968b1f65eb97fdae3f4a3 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65Test.java
8df33aba376dbe75bb41127b972ca7fa34ba1fc7 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66Test.java
3c60419928da2ab3c6c1dc673cd8d984b365c9c4 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunctionTest.java
67b5ca6fb7018936a6506abb2a848342a0e0db88 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java
d81dfd7788d0a92254bb1a25cb8164a034ec7767 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651Test.java
974fa05af38c77bf09b050c3e712e58d6307be80 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70Test.java
018993cbeae81d104482a92335305a9943fc0b44 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllTest.java
cebf9880f4e989a4fc983ec309d401e5a9480382 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallbackTest.java
112ea64f115ce23287b0f5282693eb06315f1f4c 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommand66Test.java
c86ecb49bf9121ae0528175c92376f5349197d04 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommandTest.java
fe144d7c704a974d66c550da9d28f3fb558dc6cf 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java
b2613479e621d4031322c198279e25700ae59be2 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/KeySetTest.java
5f09eaa867637a8bb6dfe93ea38766016fcedcff 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java
2b4110edaf15902586629869326625560fe850fe 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java
8a1c8701b59963c6526b9e659d401a9fe7b225a0 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java
abd664939290ba80599565cfc632779e9fd5dbe8 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61Test.java
6f6da3a421ea67d4d1c5475b67acbffb78b57d7d 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61Test.java
2b91b99a985be13f2693342070a3fbccf7290a42 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66Test.java
94163ead873ca90bcacc87052b5f60ace0111f34 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestListTest.java
514eb9be7a614439e04540ed1702891dc86ed472 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestTest.java
0b02a2c9c45a9f78c15be54251ace7bba6a6b95a 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAllTest.java
97cd58183c4e22fd143ac605d0ec15d6f857396c 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java
428ddde59bbe82999202444a2d532460ba4ebda6 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java
b894590fbacfe951663a4a925b7c35a8d60a2219 
>   geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceTest.java
01782cfaf6433c1a5ceecbd728d96153b7e3e185 
>   geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/AccessControlMBeanJUnitTest.java
626ca45f4fae3393532eab9191eaf965528dc47a 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanShiroJUnitTest.java
d0ea20980499a621e09ab197030322550bad3060 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/IntegratedSecurityServiceCustomRealmJUnitTest.java
22a7eaec1a7afbca588c5913326c9180b8b7254f 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/IntegratedSecurityServiceWithIniFileJUnitTest.java
8561f1886a22c6a4677bcc7c82c1c996fbad76c6 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/MBeanSecurityJUnitTest.java
30ed267e4f2169c1f8510188073ab4f47bea163e 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/MemberMBeanSecurityJUnitTest.java
6ae8d3f97caca585d8c0194de67716cfd680f644 
>   geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java
89030f5908d81e8f7354d989419a379a4ef5436e 
>   geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleIntegrationTest.java
4f0ea0d23d22ce77c6e083c2ce63ef4a510384bf 
>   geode-core/src/test/java/org/apache/geode/security/PDXGfshPostProcessorOnRemoteServerTest.java
c28f7aa177d6b74ad665e82aafd5beea19cfb453 
>   geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java 134e33f2bdfa6e20a0f8e6e3e82329ef58281c21

>   geode-core/src/test/java/org/apache/geode/security/SecurityManagerCallbacksDistributedTest.java
09c30f5eb52567716a751773287311e530e9ba7e 
>   geode-core/src/test/java/org/apache/geode/security/SpySecurityManager.java 11094896aa58335855950096021da70899cc2812

>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java 40cfe998780f1174da2e1ebd595cbb3862d9d73e

>   geode-core/src/test/java/org/apache/geode/test/fake/Fakes.java 6a1e26f574be254e3cea3957e14eefee14b7ed3b

>   geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
9a85c7e78ae946d15939a72f5ccd6d2af979e1b6 
>   geode-core/src/test/resources/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.ini
PRE-CREATION 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseCQ.java
18929eb18df4ab2b8f9fbd3f45fe034085f50db4 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ.java
86d53f59da16f3cc066fedfa431f1d782774ff64 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java
fcc45de38643fbb9b7d1592a9dcfcddb11d83891 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetCQStats.java
0fab30346d5838aaa207091e5a1ca05fa34dede5 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java
c14bd72e9ae20846f7118c6867ca04f1c4f84796 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MonitorCQ.java
5f0118b42f893685e72ac3c4fc95c4f6e68a4366 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/StopCQ.java
99fbef1f1e57f4550ae03d327f59c4e1b1db436b 
>   geode-cq/src/test/java/org/apache/geode/security/CQPDXPostProcessorDUnitTest.java 2489b95001c66f750d83156466069560c3308870

>   geode-cq/src/test/java/org/apache/geode/security/ClientAuthzObjectModDUnitTest.java
dd5046775811a5db419cefd0ac5f1e3eb158350a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
da0dfa23cf0d3c9bcd2dfc3d552175147c213048 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsJUnitTest.java
8deac2517aea467607fda5416144dec5cd31ee84 
>   geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/Server.java 087aff470b541ad77898d6220e2825f1905e5b05

>   geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java
3183f877d38e00670a12e92913feb517e02c9581 
>   geode-rebalancer/src/main/java/org/apache/geode/cache/util/AutoBalancer.java 0f1a995447da30b6e9b7fe396519e1925d13506b

>   geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java
06c0fb1f9f73f0b5c927ad49a3685634e4e95301 
>   geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java
f0491b7f66c4e969c7e462b0fc8abbe54e6dedfa 
>   geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java
80ff719b015ae0ffb5a648fe026bb01bc6128df8 
>   geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/SecurityServiceProvider.java
PRE-CREATION 
>   geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
00156cd75cd38374c130fc07eb4ac3a509db2c1a 
> 
> 
> Diff: https://reviews.apache.org/r/59852/diff/2/
> 
> 
> Testing
> -------
> 
> PRECHECKIN
> ==========
> 
> precheckin in progress
> 
> 1) SecurityServiceWithCustomRealmIntegrationTest failed but passes now with updated diff
> 
> JMH BENCHMARK
> =============
> 
> Result: shows an improvement of 882.061 ops/s
> 
> 1) develop results
> 
> Result "performPutFromClient":
>   10613.334 ±(99.9%) 347.392 ops/s [Average]
>   (min, avg, max) = (9075.877, 10613.334, 12341.929), stdev = 701.748
>   CI (99.9%): [10265.943, 10960.726] (assumes normal distribution)
> 
> 
> # Run complete. Total time: 02:10:36
> 
> Benchmark                                  Mode  Cnt      Score     Error  Units
> ClientCachePutBench.performPutFromClient  thrpt   50  10613.334 ± 347.392  ops/s
> 
> 2) feature/GEODE-2632-21 results
> 
> Result "performPutFromClient":
>   11495.395 ±(99.9%) 344.936 ops/s [Average]
>   (min, avg, max) = (9783.577, 11495.395, 12663.193), stdev = 696.788
>   CI (99.9%): [11150.459, 11840.331] (assumes normal distribution)
> 
> 
> # Run complete. Total time: 02:10:36
> 
> Benchmark                                  Mode  Cnt      Score     Error  Units
> ClientCachePutBench.performPutFromClient  thrpt   50  11495.395 ± 344.936  ops/s
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message