geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udo Kohlmeyer <ukohlme...@gmail.com>
Subject Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest
Date Tue, 06 Jun 2017 20:14:52 GMT


> On June 6, 2017, 6:54 p.m., Anthony Baker wrote:
> > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
> > Line 354 (original), 356 (patched)
> > <https://reviews.apache.org/r/59850/diff/1/?file=1742678#file1742678line384>
> >
> >     Did you mean to leave in prinln's?  Shouldn't this be a log statement?

I did not.. thank you.


- Udo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59850/#review177068
-----------------------------------------------------------


On June 6, 2017, 6:33 p.m., Udo Kohlmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59850/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 6:33 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Moved the socket.setSoTimeout setting to be before the SSL handshake. This is to avoid
the timeout to never be set in the case of a SSLException. Added a test to test that the socket
timeout is correctly set upon failure within the SSL configuration and handshake.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
86fe53261 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java
7c7a2b376 
>   geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/59850/diff/1/
> 
> 
> Testing
> -------
> 
> Junit test - done
> precheckin - in progress
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message