geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController
Date Mon, 05 Jun 2017 20:27:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59811/#review176946
-----------------------------------------------------------



Actually I was looking at the various size checks implemented in ExportLogsCommand, looks
like the flow is this:
1. go to each member, find out what's the combined log size that's going to be streamed to
the locator, and check if the size limit exeedes the locator's available disk space.
2. If not, export the logs down to the locator, and check if the final zip file exceeds the
user-specified file-size-limit.

I have a question on check #1, I thought we should also check the estimated size against the
user-specified value as well.

- Jinmei Liao


On June 5, 2017, 6:09 p.m., Ken Howe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59811/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 6:09 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, Patrick Rhomberg,
and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-2420: add file-size-limit param to the ExportLogsController
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
0ff780cbf66937d8ececfb3a2d0789ee485b9b62 
>   geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ExportLogController.java
a369c6e1ffb330715fbde2cd69d023ed36f133ad 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
16549e70bbebf4390bb73a481274e92ca6cad035 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
8609b3aaf0a0eb1ba903bd39c64103f9510a6a78 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
44a036298e0991c880fc552596d296e104b97ca1 
> 
> 
> Diff: https://reviews.apache.org/r/59811/diff/1/
> 
> 
> Testing
> -------
> 
> Precheckin started
> 
> 
> Thanks,
> 
> Ken Howe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message