geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinmeiliao <...@git.apache.org>
Subject [GitHub] geode pull request #548: GEODE-2818: add alias to any command's options that...
Date Mon, 05 Jun 2017 15:29:32 GMT
Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/548#discussion_r120134823
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
    @@ -412,7 +411,7 @@ public Result compactDiskStore(
           @CliOption(key = CliStrings.COMPACT_DISK_STORE__NAME, mandatory = true,
               optionContext = ConverterHint.DISKSTORE,
               help = CliStrings.COMPACT_DISK_STORE__NAME__HELP) String diskStoreName,
    -      @CliOption(key = CliStrings.COMPACT_DISK_STORE__GROUP,
    +      @CliOption(key = CliStrings.GROUP,
    --- End diff --
    
    looks like this can have "groups" as synonym as well. Can you go through all your changes
and make sure that member/group CliOption that take String[] as the option type needs to have
synonym defined. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message