geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrel Schneider <dschnei...@pivotal.io>
Subject Re: Review Request 59564: GEODE-2892 implement sizeOnSever and isEmptyOnServer
Date Thu, 01 Jun 2017 00:26:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59564/#review176560
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/cache/Region.java
Lines 2100 (patched)
<https://reviews.apache.org/r/59564/#comment249946>

    Drop the "int". Do the same on the size javadocs


- Darrel Schneider


On May 31, 2017, 4:35 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59564/
> -----------------------------------------------------------
> 
> (Updated May 31, 2017, 4:35 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn Gallinat.
> 
> 
> Bugs: GEODE-2892
>     https://issues.apache.org/jira/browse/GEODE-2892
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> implement sizeOnSever and isEmptyOnServer
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/Region.java 0fa29c6 
>   geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java e35750b

>   geode-core/src/main/java/org/apache/geode/internal/admin/remote/AdminRegion.java 51f1fdb

>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalDataSet.java 8be8de1

>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java f581856 
>   geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/RegionCreation.java
a107fb3 
>   geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java f19c4e7

>   geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionJUnitTest.java
ce83165 
>   geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
9ca5ab9 
>   geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationTestCase.java
d1eddbb 
>   geode-core/src/test/java/org/apache/geode/security/SecurityTestUtils.java 2b26cdc 
> 
> 
> Diff: https://reviews.apache.org/r/59564/diff/3/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Eric Shu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message