Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 75D08200C80 for ; Thu, 25 May 2017 20:11:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 74796160BB4; Thu, 25 May 2017 18:11:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BA970160BCA for ; Thu, 25 May 2017 20:11:06 +0200 (CEST) Received: (qmail 92181 invoked by uid 500); 25 May 2017 18:11:05 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 92170 invoked by uid 99); 25 May 2017 18:11:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 18:11:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 78E0DC0DC7 for ; Thu, 25 May 2017 18:11:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YWbw1K9cNno7 for ; Thu, 25 May 2017 18:11:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B89585F477 for ; Thu, 25 May 2017 18:11:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4782FE0012 for ; Thu, 25 May 2017 18:11:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 058522193C for ; Thu, 25 May 2017 18:11:04 +0000 (UTC) Date: Thu, 25 May 2017 18:11:04 +0000 (UTC) From: "Jared Stewart (JIRA)" To: dev@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (GEODE-2989) Improve mechanism for scanning the classpath to find gfsh commands MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 25 May 2017 18:11:07 -0000 Jared Stewart created GEODE-2989: ------------------------------------ Summary: Improve mechanism for scanning the classpath to find gfsh commands Key: GEODE-2989 URL: https://issues.apache.org/jira/browse/GEODE-2989 Project: Geode Issue Type: Improvement Components: gfsh, management Reporter: Jared Stewart The current mechanism for scanning the classpath to find gfsh commands (ClasspathScanLoadHelper) has some deficiencies, including: 1) Commands can only be scanned for in an exact package ("org.apache.geode.management.internal.cli.commands"). We can't pick up commands from any subpackages, prevents us from better organizing the package structure of our commands (e.g. "org.apache.geode.management.internal.cli.commands.lifecycle"). 2) All classes in the target package are eagerly loaded, whether or not they contain commands. Both of these deficiencies can be removed if we replace the implementation of ClasspathScanLoadHelper with calls to FastClasspathScanner. -- This message was sent by Atlassian JIRA (v6.3.15#6346)