Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8D3E6200C7F for ; Wed, 24 May 2017 23:51:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8BDAB160BD0; Wed, 24 May 2017 21:51:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D3302160BA5 for ; Wed, 24 May 2017 23:51:07 +0200 (CEST) Received: (qmail 30092 invoked by uid 500); 24 May 2017 21:51:07 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 30080 invoked by uid 99); 24 May 2017 21:51:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 21:51:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 97AFAC18AA for ; Wed, 24 May 2017 21:51:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id R8ncWGoS85i6 for ; Wed, 24 May 2017 21:51:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 776AC5FDD2 for ; Wed, 24 May 2017 21:51:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C8CC0E0D4D for ; Wed, 24 May 2017 21:51:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 26AB021B5A for ; Wed, 24 May 2017 21:51:04 +0000 (UTC) Date: Wed, 24 May 2017 21:51:04 +0000 (UTC) From: "Kenneth Howe (JIRA)" To: dev@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (GEODE-2984) Gfsh command error handling should use exceptions rather than status returns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 21:51:08 -0000 [ https://issues.apache.org/jira/browse/GEODE-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Howe reassigned GEODE-2984: ----------------------------------- Assignee: Kenneth Howe > Gfsh command error handling should use exceptions rather than status returns > ---------------------------------------------------------------------------- > > Key: GEODE-2984 > URL: https://issues.apache.org/jira/browse/GEODE-2984 > Project: Geode > Issue Type: Bug > Components: gfsh > Reporter: Jared Stewart > Assignee: Kenneth Howe > > Currently, a given gfsh command either returns an InfoResultData (in the happy case) or an ErrorResultData (in the exceptional case). This requires putting error handling code inside of *each* command separately. It would be far better to instead allow gfsh commands throw an exception, and to have GfshExecutionStrategy (or somewhere similar) handle wrapping up any exception into an ErrorResultData in a generic fashion. > It may also be worth looking at the built-in mechanism in Spring Shell for this strategy (see afterThrowingInvocation): http://docs.spring.io/autorepo/docs/spring-shell/1.2.0.M1/api/org/springframework/shell/core/ExecutionProcessor.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)