Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Tue, 30 May 2017 17:12:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@geode.apache.org
Message-ID: <JIRA.13073525.1495219003000.322382.1496164324394@Atlassian.JIRA>
In-Reply-To: <JIRA.13073525.1495219003000@Atlassian.JIRA>
References: <JIRA.13073525.1495219003000@Atlassian.JIRA> <JIRA.13073525.1495219003658@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-2957) null used as a default parameter
 when specifying analyzers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 30 May 2017 17:12:54 -0000


    [ https://issues.apache.org/jira/browse/GEODE-2957?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1602=
9757#comment-16029757 ]=20

ASF GitHub Bot commented on GEODE-2957:
---------------------------------------

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/547

    GEODE-2957: Create Lucene index analyzer help updated to include keyw=
=E2=80=A6

    =E2=80=A6ord DEFAULT
   =20
    Thank you for submitting a contribution to Apache Geode.
   =20
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
   =20
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced =
in the commit message?
   =20
    - [ ] Has your PR been rebased against the latest commit within the tar=
get branch (typically `develop`)?
   =20
    - [ ] Is your initial contribution a single, squashed commit?
   =20
    - [ ] Does `gradlew build` run cleanly?
   =20
    - [ ] Have you written or updated unit tests to verify your changes?
   =20
    - [ ] If adding new dependencies to the code, are these dependencies li=
censed in a way that is compatible for inclusion under [ASF 2.0](http://www=
.apache.org/legal/resolved.html#category-a)?
   =20
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for bu=
ild issues and
    submit an update to your PR as soon as possible. If you need help, plea=
se send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-2957

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #547
   =20
----
commit 0e37c14c01dd5ceb853f337c6c45c6287e6ccd7f
Author: David Anuta <david.r.anuta@gmail.com>
Date:   2017-05-30T16:27:11Z

    GEODE-2957: Create Lucene index analyzer help updated to include keywor=
d DEFAULT

----


> null used as a default parameter when specifying analyzers
> ----------------------------------------------------------
>
>                 Key: GEODE-2957
>                 URL: https://issues.apache.org/jira/browse/GEODE-2957
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Jason Huynh
>            Assignee: David Anuta
>             Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default StandardKeywordAnal=
yzer. This can be used when specifying a long list of field/analyzers. =20
> So the line may look like --analyzers=3D"null,SomeAnalyzer,null,null,Some=
Analyzer}
>  We should probably change that to default or some other keyword.  null s=
eems a bit confusing.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)