Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6EA5D200C79 for ; Fri, 19 May 2017 19:27:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6D347160BB0; Fri, 19 May 2017 17:27:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B61CA160BD2 for ; Fri, 19 May 2017 19:27:08 +0200 (CEST) Received: (qmail 53283 invoked by uid 500); 19 May 2017 17:27:07 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 52968 invoked by uid 99); 19 May 2017 17:27:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 May 2017 17:27:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7CC141883D6 for ; Fri, 19 May 2017 17:27:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id HlAwn0z_FzvH for ; Fri, 19 May 2017 17:27:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 632895FD8E for ; Fri, 19 May 2017 17:27:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BAF40E0D4D for ; Fri, 19 May 2017 17:27:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2ED2921B5C for ; Fri, 19 May 2017 17:27:04 +0000 (UTC) Date: Fri, 19 May 2017 17:27:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-1994) Change geode StringUtils to extend commons StringUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 19 May 2017 17:27:09 -0000 [ https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017700#comment-16017700 ] ASF GitHub Bot commented on GEODE-1994: --------------------------------------- Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/521 Green across the board, excepting the flaky test `testRegionAggregate` which is becoming increasingly less flaky and more consistently red. > Change geode StringUtils to extend commons StringUtils > ------------------------------------------------------ > > Key: GEODE-1994 > URL: https://issues.apache.org/jira/browse/GEODE-1994 > Project: Geode > Issue Type: Wish > Components: general, management > Reporter: Kirk Lund > Assignee: Patrick Rhomberg > > org.apache.geode.internal.lang.StringUtils duplicates some of the methods in org.apache.commons.lang.StringUtils with some inconsistencies. > isBlank is implemented identically > isEmpty is inconsistent -- commons version returns true if string is null, while geode version returns false if string is null -- This message was sent by Atlassian JIRA (v6.3.15#6346)