Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8B292200C6E for ; Mon, 8 May 2017 18:57:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 89F59160BA2; Mon, 8 May 2017 16:57:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8DBA160BA5 for ; Mon, 8 May 2017 18:57:09 +0200 (CEST) Received: (qmail 60515 invoked by uid 500); 8 May 2017 16:57:08 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 60504 invoked by uid 99); 8 May 2017 16:57:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 May 2017 16:57:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 33B82CA9F4 for ; Mon, 8 May 2017 16:57:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id TRQ8pSiaeskF for ; Mon, 8 May 2017 16:57:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EA0DC5FDBE for ; Mon, 8 May 2017 16:57:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1C033E0D2F for ; Mon, 8 May 2017 16:57:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 194A821DFB for ; Mon, 8 May 2017 16:57:05 +0000 (UTC) Date: Mon, 8 May 2017 16:57:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-234) remove deprecated MirrorType class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 08 May 2017 16:57:10 -0000 [ https://issues.apache.org/jira/browse/GEODE-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001084#comment-16001084 ] ASF GitHub Bot commented on GEODE-234: -------------------------------------- Github user dschneider-pivotal commented on the issue: https://github.com/apache/geode/pull/495 The xsd you are looking for is: geode-core/build/resources/main/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd However you should not modify this one since it has already been released. The next geode release will be 1.2 so you would want to create a new cache-1.2.xsd and remove mirror-type from it. Introducing a new xsd involves a bunch of busy work. You need to add org.apache.geode.internal.cache.xmlcache.CacheXml.VERSION_1_2, update CacheXml.VERSION_LATEST, add CacheXml.SCHEMA_1_2_LOCATION, add CacheXmlVersion.GEODE_1_2, add CacheXmlGeode12DUnitTest that extends CacheXmlGeode10DUnitTest. I'm not sure what should be done about these dunit tests. They test the old xsd/dtds which still do support mirror-type. If we remove support for the mirror-type attribute from the xml parser code then all these old dtds and xsds will no longer support mirror-type in their xml even though the old dtd/xsd says it does. I think all the old dtds we still support also have data-policy so even with that old dtd you could convert the mirror-type attribute to data-policy in you existing xml. > remove deprecated MirrorType class > ---------------------------------- > > Key: GEODE-234 > URL: https://issues.apache.org/jira/browse/GEODE-234 > Project: Geode > Issue Type: Sub-task > Reporter: Darrel Schneider > Assignee: Avinash Dongre > > All uses of MirrorType should be changed to use DataPolicy.REPLICATE. > All apis that take it as a parameter or return it need to be deleted. > The cache-9.0.xsd should also be changed to no longer have the "mirror-type" region-attribute. -- This message was sent by Atlassian JIRA (v6.3.15#6346)