Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
From: jaredjstewart <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-549-geode@git.apache.org>
In-Reply-To: <git-pr-549-geode@git.apache.org>
Subject: [GitHub] geode pull request #549: GEODE-2203: gfsh status locator/server - Command no...
Content-Type: text/plain
Message-Id: <20170530224233.8A6A6DFFB5@git1-us-west.apache.org>
Date: Tue, 30 May 2017 22:42:33 +0000 (UTC)
archived-at: Tue, 30 May 2017 22:42:35 -0000

Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/549#discussion_r119233486
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java ---
    @@ -771,11 +771,18 @@ public Result statusLocator(
                   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, LOCATOR_TERM_NAME));
             }
           } else {
    -        final LocatorLauncher locatorLauncher =
    -            new LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
    -                .setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
    -                .setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
    +        final LocatorLauncher locatorLauncher;
     
    +        if ((locatorHost == null) && (locatorPort == null) && (workingDirectory == null)) {
    --- End diff --
    
    Looking into this a bit further, I think we probably will need to add `&& (pid == null)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---