Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A7BEF200C80 for ; Thu, 25 May 2017 21:06:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A6845160BD5; Thu, 25 May 2017 19:06:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 011FE160BB4 for ; Thu, 25 May 2017 21:06:11 +0200 (CEST) Received: (qmail 39161 invoked by uid 500); 25 May 2017 19:06:06 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 39007 invoked by uid 99); 25 May 2017 19:06:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 19:06:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 80D8CCFDB9; Thu, 25 May 2017 19:06:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lmWlScT4Bctg; Thu, 25 May 2017 19:06:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C51EF5F5CA; Thu, 25 May 2017 19:06:03 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 14207E01D8; Thu, 25 May 2017 19:06:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0CEF7C4005D; Thu, 25 May 2017 19:06:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6056780868253806394==" MIME-Version: 1.0 Subject: Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start From: Hitesh Khamesra To: Udo Kohlmeyer , Galen O'Sullivan , Bruce Schuchardt Cc: geode , Hitesh Khamesra Date: Thu, 25 May 2017 19:06:03 -0000 Message-ID: <20170525190603.10155.94112@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Hitesh Khamesra X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59546/ X-Sender: Hitesh Khamesra References: <20170525171241.10155.41081@reviews-vm2.apache.org> In-Reply-To: <20170525171241.10155.41081@reviews-vm2.apache.org> Reply-To: Hitesh Khamesra X-ReviewRequest-Repository: geode archived-at: Thu, 25 May 2017 19:06:12 -0000 --===============6056780868253806394== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59546/ ----------------------------------------------------------- (Updated May 25, 2017, 7:06 p.m.) Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer. Changes ------- Updated diff; removed commented code Repository: geode Description ------- We configure locator list to start the cache. This locator list is validated while creating the cache. We verify whether locator host exist or not. Now we have remove this verification as in cloud environment host may not available for time being. Patch from Bruce. Modified couple of tests. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93 geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157 geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 7caad3f geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1 geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java dc73f04 geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 9cff80d geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c Diff: https://reviews.apache.org/r/59546/diff/2/ Changes: https://reviews.apache.org/r/59546/diff/1-2/ Testing ------- Thanks, Hitesh Khamesra --===============6056780868253806394==--