Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Content-Type: multipart/alternative;
 boundary="===============6116003705297862945=="
MIME-Version: 1.0
Subject: Re: Review Request 59057: GEODE-2193 a member is kicked out
 immediately after joining
From: Hitesh Khamesra <hkhamesra@pivotal.io>
To: Udo Kohlmeyer <ukohlmeyer@gmail.com>,
 Galen O'Sullivan <gosullivan@pivotal.io>,
 Hitesh Khamesra <hkhamesra@pivotal.io>
Cc: geode <dev@geode.apache.org>, Bruce Schuchardt <bschuchardt@pivotal.io>
Date: Mon, 08 May 2017 19:03:45 -0000
Message-ID: <20170508190345.23035.70@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Hitesh Khamesra <noreply@reviews.apache.org>
References: <20170508174423.23035.82536@reviews-vm2.apache.org>
In-Reply-To: <20170508174423.23035.82536@reviews-vm2.apache.org>
Reply-To: Hitesh Khamesra <hkhamesra@pivotal.io>
archived-at: Mon, 08 May 2017 19:03:55 -0000

--===============6116003705297862945==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On May 8, 2017, 5:44 p.m., Hitesh Khamesra wrote:
> >

How about sending pending joinRequest(new member) with shutdown message. And let new coordinator take care of it.


- Hitesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59057/#review174198
-----------------------------------------------------------


On May 8, 2017, 5:23 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59057/
> -----------------------------------------------------------
> 
> (Updated May 8, 2017, 5:23 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2193
>     https://issues.apache.org/jira/browse/GEODE-2193
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The previous fix for this ticket introduced a shutdown problem that caused servers to pause waiting for ShutdownMessage to be sent to another server that had already exited.  We reduced the pause time but this change set fixes the problem by transmitting the message over UDP instead of TCP/IP stream sockets.
> 
> Another change in GMSJoinLeave prepareView/sendView allows a membership coordinator that is shutting down to complete the sending out of a new view if it has already prepared the view when shutdown begins.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java e0c0ba29a5c74614d2430fb78d972e306a355845 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 8ae66d0b6839cfbd46b479d896104f54fd11a68d 
>   geode-core/src/main/java/org/apache/geode/internal/util/PluckStacks.java 357812a6ec0cb09a88fa727a4bf828f18794264d 
> 
> 
> Diff: https://reviews.apache.org/r/59057/diff/2/
> 
> 
> Testing
> -------
> 
> precheckin plus 1000 runs of the test that was hitting this issue at least 4% of the time
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


--===============6116003705297862945==--