Return-Path: <dev-return-21001-archive-asf-public=cust-asf.ponee.io@geode.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 210AE200C8E
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  4 May 2017 01:18:02 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 1FB11160BB5; Wed,  3 May 2017 23:18:02 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5DA6E160BBA
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  4 May 2017 01:18:01 +0200 (CEST)
Received: (qmail 49126 invoked by uid 500); 3 May 2017 23:18:00 -0000
Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@geode.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@geode.apache.org>
List-Post: <mailto:dev@geode.apache.org>
List-Id: <dev.geode.apache.org>
Reply-To: dev@geode.apache.org
Delivered-To: mailing list dev@geode.apache.org
Received: (qmail 49002 invoked by uid 99); 3 May 2017 23:18:00 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 23:18:00 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1DFC2DF984; Wed,  3 May 2017 23:18:00 +0000 (UTC)
From: kirklund <git@git.apache.org>
To: dev@geode.apache.org
Reply-To: dev@geode.apache.org
References: <git-pr-475-geode@git.apache.org>
In-Reply-To: <git-pr-475-geode@git.apache.org>
Subject: [GitHub] geode pull request #475: GEODE-2812: Add API to get list of live locators
Content-Type: text/plain
Message-Id: <20170503231800.1DFC2DF984@git1-us-west.apache.org>
Date: Wed,  3 May 2017 23:18:00 +0000 (UTC)
archived-at: Wed, 03 May 2017 23:18:02 -0000

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/475#discussion_r114674893
  
    --- Diff: geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java ---
    @@ -253,12 +263,15 @@ protected void updateLocatorList(LocatorListResponse response) {
         List<ServerLocation> locatorResponse = response.getLocators();
     
         List<InetSocketAddress> newLocators = new ArrayList<InetSocketAddress>(locatorResponse.size());
    +    List<InetSocketAddress> activeLocators =
    --- End diff --
    
    I think "active" is another adjective where you should consider using "online" instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---