From dev-return-21678-apmail-geode-dev-archive=geode.apache.org@geode.apache.org Thu May 11 21:24:10 2017 Return-Path: X-Original-To: apmail-geode-dev-archive@minotaur.apache.org Delivered-To: apmail-geode-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 378BF19FFF for ; Thu, 11 May 2017 21:24:10 +0000 (UTC) Received: (qmail 35742 invoked by uid 500); 11 May 2017 21:24:10 -0000 Delivered-To: apmail-geode-dev-archive@geode.apache.org Received: (qmail 35687 invoked by uid 500); 11 May 2017 21:24:10 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 35498 invoked by uid 99); 11 May 2017 21:24:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 21:24:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7C5821A0512 for ; Thu, 11 May 2017 21:24:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DYjcFr0svnL1 for ; Thu, 11 May 2017 21:24:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9A4095FD21 for ; Thu, 11 May 2017 21:24:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DB20DE0D68 for ; Thu, 11 May 2017 21:24:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9B95921E19 for ; Thu, 11 May 2017 21:24:04 +0000 (UTC) Date: Thu, 11 May 2017 21:24:04 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-2883) gfsh gc reports incorrect heap sizes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007221#comment-16007221 ] ASF subversion and git services commented on GEODE-2883: -------------------------------------------------------- Commit 68935caea1d158375d6bf94c73c8f685eda01211 in geode's branch refs/heads/feature/GEODE-2632-15 from [~jstewart] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=68935ca ] GEODE-2883: Fix GFSH gc heap size output > gfsh gc reports incorrect heap sizes > ------------------------------------ > > Key: GEODE-2883 > URL: https://issues.apache.org/jira/browse/GEODE-2883 > Project: Geode > Issue Type: Bug > Components: gfsh > Affects Versions: 1.0.0-incubating, 1.1.0, 1.1.1 > Reporter: Barry Oglesby > Assignee: Jared Stewart > Fix For: 1.2.0 > > > I have 3 servers each with -Xms1g and -Xmx1g, and I load some data. > If I run a gfsh gc, it reports: > {noformat} > GC Summary > Member ID/Name | HeapSize (MB) Before GC | HeapSize(MB) After GC | Time Taken for GC in ms > --------------------------- | ----------------------- | --------------------- | ----------------------- > 192.168.2.7(98588):1025 | 2078 | 1098 | 516 > 192.168.2.7(98602):1027 | 1942 | 1110 | 530 > 192.168.2.7(98595):1026 | 2019 | 1109 | 531 > {noformat} > The heap sizes before and after are higher than they should be. > I added some debugging in the GarbageCollectionFunction, and it shows: > {noformat} > GarbageCollectionFunction.execute freeMemoryBeforeGC=765581248; totalMemoryBeforeGC=1037959168 > GarbageCollectionFunction.execute freeMemoryAfterGC=893946464; totalMemoryAfterGC=1037959168 > GarbageCollectionFunction.execute HeapSizeBeforeGC=2078 > GarbageCollectionFunction.execute HeapSizeAfterGC=1098 > GarbageCollectionFunction.execute freeMemoryBeforeGC=773307528; totalMemoryBeforeGC=1037959168 > GarbageCollectionFunction.execute freeMemoryAfterGC=892508088; totalMemoryAfterGC=1037959168 > GarbageCollectionFunction.execute HeapSizeBeforeGC=2019 > GarbageCollectionFunction.execute HeapSizeAfterGC=1109 > GarbageCollectionFunction.execute freeMemoryBeforeGC=783373464; totalMemoryBeforeGC=1037959168 > GarbageCollectionFunction.execute freeMemoryAfterGC=892349664; totalMemoryAfterGC=1037959168 > GarbageCollectionFunction.execute HeapSizeBeforeGC=1942 > GarbageCollectionFunction.execute HeapSizeAfterGC=1110 > {noformat} > The free and total memory are fine, but the heap sizes before and after are incorrect. > The function is using 131072 as its divisor > {noformat} > 1037959168-765581248=272377920 / 131072 = 2078 > 1037959168-893946464=144012704 / 131072 = 1098 > {noformat} > It should be using 1024*1024. > {noformat} > 1037959168-765581248=272377920 / (1024*1024) = 259 > 1037959168-893946464=144012704 / (1024*1024) = 137 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346)