geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully
Date Thu, 25 May 2017 02:21:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024064#comment-16024064
] 

ASF GitHub Bot commented on GEODE-2986:
---------------------------------------

GitHub user AkihiroKitada opened a pull request:

    https://github.com/apache/geode/pull/535

    GEODE-2986: Remove redundant log message

    Just log message if "notExecutedMembers" is not null and not empty.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AkihiroKitada/geode feature/GEODE-2986

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #535
    
----
commit 28face3833cb33bc6e23ef5f872a68bfc0917bcc
Author: Akihiro Kitada <akitada@akitada-mcbk13.local>
Date:   2017-05-25T02:16:08Z

    GEODE-2986: Remove redundant log message
    
    Just log message if "notExecutedMembers" is not null and not empty.

----


> Need not to log message when executing "gfsh compact disk-store" command successfully
> -------------------------------------------------------------------------------------
>
>                 Key: GEODE-2986
>                 URL: https://issues.apache.org/jira/browse/GEODE-2986
>             Project: Geode
>          Issue Type: Wish
>          Components: persistence
>            Reporter: Akihiro Kitada
>
> When executing "gfsh compact disk-store" command, then we currently see the following
kind of message if the command is successfully executed for all the target members.
> {noformat}
> compact disk-store "DEFAULT" message was scheduled to be sent to but was not send to
null
> {noformat}
> This message is not friendly to know what was going on.
> Need not to log such kind of message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message