geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration
Date Tue, 30 May 2017 21:13:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030138#comment-16030138
] 

ASF GitHub Bot commented on GEODE-2975:
---------------------------------------

Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/538
  
    @boglesby - I see the problem with lucene:indexxx. It looks like in cache-1.0.xsd, which
specify this in order to allow other schemas (like lucene.xsd) to extend region with additional
elements:
    
    `
          <xsd:any namespace="##other" processContents="lax" minOccurs="0" maxOccurs="unbounded"/>
    `
    
    Unfortunately, using 'lax' instead of 'strict' here means that we don't validate the new
xsd as strictly - additional elements are ignored, etc.
    
    I'm worried about the impact of changing this validation. I think the thing to do maybe
is just to give a little better error message in our java code and call it a day.


> Attributes are not validated in lucene xml configuration
> --------------------------------------------------------
>
>                 Key: GEODE-2975
>                 URL: https://issues.apache.org/jira/browse/GEODE-2975
>             Project: Geode
>          Issue Type: Bug
>          Components: docs, lucene
>            Reporter: Barry Oglesby
>             Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required attribute.
> No exception is thrown for a lucene xml configuration including an unknown attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown for the invalid
attribute called {{namexx}} and no exceptio is thrown because the required attribute called
{{name}} is not included.
> {noformat}
> <lucene:field namexx="Agency"/>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message