geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration
Date Thu, 25 May 2017 20:10:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025308#comment-16025308
] 

ASF GitHub Bot commented on GEODE-2975:
---------------------------------------

GitHub user upthewaterspout opened a pull request:

    https://github.com/apache/geode/pull/538

    GEODE-2975: Change the location of the lucene xsd

    The lucene xsd was not in the right location on disk, which resulted in
    a failure to validate lucene elements in the xml file.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    - [X] Does `gradlew build` run cleanly?
    
    - [X] Have you written or updated unit tests to verify your changes?
    
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/geode feature/GEODE-2975

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #538
    
----
commit 313febd9eb1cc2b89ab790d00183010b9d5d27b2
Author: Dan Smith <upthewaterspout@apache.org>
Date:   2017-05-25T20:05:23Z

    GEODE-2975: Change the location of the lucene xsd
    
    The lucene xsd was not in the right location on disk, which resulted in
    a failure to validate lucene elements in the xml file.

----


> Attributes are not validated in lucene xml configuration
> --------------------------------------------------------
>
>                 Key: GEODE-2975
>                 URL: https://issues.apache.org/jira/browse/GEODE-2975
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Barry Oglesby
>             Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required attribute.
> No exception is thrown for a lucene xml configuration including an unknown attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown for the invalid
attribute called {{namexx}} and no exceptio is thrown because the required attribute called
{{name}} is not included.
> {noformat}
> <lucene:field namexx="Agency"/>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message