geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers
Date Tue, 30 May 2017 17:12:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029757#comment-16029757
] 

ASF GitHub Bot commented on GEODE-2957:
---------------------------------------

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/547

    GEODE-2957: Create Lucene index analyzer help updated to include keyw…

    …ord DEFAULT
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-2957

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #547
    
----
commit 0e37c14c01dd5ceb853f337c6c45c6287e6ccd7f
Author: David Anuta <david.r.anuta@gmail.com>
Date:   2017-05-30T16:27:11Z

    GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT

----


> null used as a default parameter when specifying analyzers
> ----------------------------------------------------------
>
>                 Key: GEODE-2957
>                 URL: https://issues.apache.org/jira/browse/GEODE-2957
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Jason Huynh
>            Assignee: David Anuta
>             Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default StandardKeywordAnalyzer. This can
be used when specifying a long list of field/analyzers.  
> So the line may look like --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message