geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2929) Remove superfluous uses of final from classes and methods
Date Mon, 15 May 2017 22:30:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011437#comment-16011437
] 

ASF subversion and git services commented on GEODE-2929:
--------------------------------------------------------

Commit a63457b7ac580c4ac7ff520fbf475d87de4f62b8 in geode's branch refs/heads/feature/GEODE-2929
from [~apache@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a63457b ]

GEODE-2929: remove superfluous use of final from class declarations


> Remove superfluous uses of final from classes and methods
> ---------------------------------------------------------
>
>                 Key: GEODE-2929
>                 URL: https://issues.apache.org/jira/browse/GEODE-2929
>             Project: Geode
>          Issue Type: Wish
>          Components: core
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>
> Use of final keyword on classes and methods should be reserved for unique situations
in the User API where we really need final to prevent a User from overriding something in
the API.
> Superfluous usage of final on classes and methods hinders good unit testing by preventing
mocking of those classes and methods.
> Any unnecessary usage of final should be removed to facilitate mocking.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message