geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region
Date Mon, 01 May 2017 18:49:04 GMT


ASF GitHub Bot commented on GEODE-2828:

Github user nabarunnag commented on a diff in the pull request:
    --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/
    @@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
         // create PR fileAndChunkRegion, but not to create its buckets for now
         final String fileRegionName = createFileRegionName();
         PartitionAttributes partitionAttributes = dataRegion.getPartitionAttributes();
    -    // create PR chunkRegion, but not to create its buckets for now
    -    // we will create RegionDirectories on the fly when data comes in
    -    HeterogeneousLuceneSerializer mapper = new HeterogeneousLuceneSerializer(getFieldNames());
    -    PartitionedRepositoryManager partitionedRepositoryManager =
    -        new PartitionedRepositoryManager(this, mapper);
         DM dm = this.cache.getInternalDistributedSystem().getDistributionManager();
         LuceneBucketListener lucenePrimaryBucketListener =
    -        new LuceneBucketListener(partitionedRepositoryManager, dm);
    +        new LuceneBucketListener((PartitionedRepositoryManager) partitionedRepositoryManager,
    --- End diff --
    I made createLuceneListenerAndFileChunkRegion method take in PartitionedRepositoryManager
    which removed all the casting in the but I would like
a suggestion on how to remove the casting in createLuceneListenersAndFileChunkRegions(  (PartitionedRepositoryManager)
repositoryManager); in the file. As the repositoryManager is being created
by createRepositoryManager() which creates  repository manager for both RawLuceneIndex as
well as LuceneIndexForPartitionRegion

> AEQ needs to be created before the user region
> ----------------------------------------------
>                 Key: GEODE-2828
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>            Reporter: nabarun
> Issue:
> Events are lost as the region is being created, because the AEQ gets created after the
user region is created, and the indexes are not being created via AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and starts processing
after the user region is created.

This message was sent by Atlassian JIRA

View raw message