geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators
Date Thu, 11 May 2017 15:45:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006654#comment-16006654
] 

ASF GitHub Bot commented on GEODE-2788:
---------------------------------------

Github user bschuchardt commented on the issue:

    https://github.com/apache/geode/pull/474
  
    There is another failure in AnalyzeSerializablesJUnitTest caused by this change.  Certain
tests serilalize/deserialize PoolAttributes, so this class is DataSerializable.  This PR changes
the serialized form of the class, so the sanctionedSerializables.txt file must be updated
to reflect that this change is acceptable:
    
    
    org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest > testDataSerializables
FAILED
        java.lang.AssertionError: Modified classes--------------------------------------------
        org/apache/geode/internal/cache/PoolFactoryImpl$PoolAttributes,2
        fromData,153,2a2bb80034b500052a2bb80034b500072a2bb80034b500092a2bb80034b5000b2a2bb80034b5000c2a2bb80034b5000d2a2bb80034b500112a2bb80035b500102a2bb80035b500142a2bb80034b500182a2bb80034b5001a2a2bb80036b5000a2a2bb80036b500162a2bb80037b5001d2a2bb80038b500212a2bb80038b500222a2bb80034b500152a2bb80036b5001e2a2bb80034b50004b1
        toData,153,2ab400052bb8002f2ab400072bb8002f2ab400092bb8002f2ab4000b2bb8002f2ab4000c2bb8002f2ab4000d2bb8002f2ab400112bb8002f2ab400102bb800302ab400142bb800302ab400182bb8002f2ab4001a2bb8002f2ab4000a2bb800312ab400162bb800312ab4001d2bb800322ab400212bb800332ab400222bb800332ab400152bb8002f2ab4001e2bb800312ab400042bb8002fb1
        :  toData (len=153,expected=145), and fromData (len=153,expected=145)
    
    
        If the class is not persisted or sent over the wire add it to the excludedClasses.txt
file in the 
        org/apache/geode/codeAnalysis directory.  Otherwise if this doesn't 
        break backward compatibility move the file actualDataSerializables.dat to the codeAnalysis

        test directory and rename to sanctionedDataSerializables.txt
            at org.junit.Assert.fail(Assert.java:88)
            at org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest.testDataSerializables(AnalyzeSerializablesJUnitTest.java:188)



> Add official Socket timeout parameter when connecting to servers/locators
> -------------------------------------------------------------------------
>
>                 Key: GEODE-2788
>                 URL: https://issues.apache.org/jira/browse/GEODE-2788
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server, docs
>            Reporter: Masaki Yamakawa
>            Priority: Minor
>              Labels: patch
>
> When connecting from the client to the servers/locators, if the servers/locators is not
started, the connection can not be established and a Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. This timeout
value can be changed by specifying the unofficial parameter "gemfire.PoolImpl.HANDSHAKE_TIMEOUT"
in java system property, but I corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by "connect-timeout"
in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as an attribute
of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message