geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2741) Use C++11 shared pointer over custom shared pointer
Date Wed, 17 May 2017 17:15:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014431#comment-16014431
] 

ASF GitHub Bot commented on GEODE-2741:
---------------------------------------

GitHub user pivotal-jbarrett opened a pull request:

    https://github.com/apache/geode-native/pull/99

    GEODE-2741: Remove custom shared painter and replace with std::shared_ptr.

    Tests pass on Linux, Windows, Solaris and Mac.
    
    Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pivotal-jbarrett/geode-native wip/shared_ptr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode-native/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit c0098121eb9b8ee7d537ac0d0bb767ebb6d46927
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   2017-03-29T00:34:29Z

    GEODE-2741: Remove custom shared pointer from cppcache

commit 6027574a2078b35fadcef450020af775415f1c36
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   2017-04-21T22:59:27Z

    GEODE-2741: Remove custom shared pointer from clicache

commit 9a06e1681438c01e3f721f4a3f7b7576bedefd2a
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   2017-05-16T13:24:16Z

    GEODE-2741: Backs out workaround for .NET Environment.Exit issues.

commit c6fdafe5793afd057e95b5fbb3d07b88665d1043
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   2017-05-16T20:29:56Z

    GEODE-2741: Fix casting issues between generics.

commit 3cb20df08f6b5d624b75609e54354a077b5fcc03
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   2017-05-16T22:29:14Z

    GEODE-2741: Fixes potential memory leak on exception.

commit d58a5e30d42ae38fd9a439fe875bb9096cdde386
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   2017-05-17T03:26:35Z

    GEODE-2741: Fixes inclusion of unmanaged headers.

commit 767033e5cfd70b3ad41cac67d63db464b3697a85
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   2017-05-17T04:09:22Z

    GEODE-2741: Workaround for static de-init issues with CLR.

----


> Use C++11 shared pointer over custom shared pointer
> ---------------------------------------------------
>
>                 Key: GEODE-2741
>                 URL: https://issues.apache.org/jira/browse/GEODE-2741
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Addison
>            Assignee: Jacob S. Barrett
>
> *Context*
> Now that the Native Client is compatible with C++11, we can use its shared pointer over
the custom shared pointer we use today.
> *Definition of Done*
> The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message