geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-254) Remove deprecated Region.keys and Region.entries
Date Mon, 08 May 2017 19:29:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001395#comment-16001395
] 

ASF GitHub Bot commented on GEODE-254:
--------------------------------------

Github user dschneider-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/488#discussion_r115331983
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java
---
    @@ -1702,6 +1702,8 @@ public Set entrySet(boolean recursive) {
         return entries(recursive);
       }
     
    +  public abstract Set entries(boolean recursive);
    --- End diff --
    
    Why add this abstract method when you are getting rid of entries(boolean)?


> Remove deprecated Region.keys and Region.entries
> ------------------------------------------------
>
>                 Key: GEODE-254
>                 URL: https://issues.apache.org/jira/browse/GEODE-254
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Avinash Dongre
>             Fix For: 1.2.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Remove the deprecated Region.keys and Region.entries. Any calls can be simply changed
to Region.keySet and Region.entrySet so this should be an easy change.
> A large number of tests call the deprecated methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message