geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-240) Remove deprecated methods on TransactionEvent
Date Tue, 16 May 2017 16:44:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012706#comment-16012706
] 

ASF GitHub Bot commented on GEODE-240:
--------------------------------------

GitHub user shankarh opened a pull request:

    https://github.com/apache/geode/pull/515

    GEODE-240: Remove deprecated methods on TransactionEvent

    Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents
from the TransactionEvent.
    Removed implementation for methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents
from TxEvent and TxRmtEvent.
    Added utility methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents
in TxEventTestUtil.
    Changed tests to use the new utilty methods from TxEventTestUtil.
    
    Signed-off-by: Shankar <shankarh@apache.org>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    Yes.  GEODE-240
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    Yes.
    - [ ] Is your initial contribution a single, squashed commit?
    Yes.
    - [ ] Does `gradlew build` run cleanly?
    Yes.
    - [ ] Have you written or updated unit tests to verify your changes?
    Yes.
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    Not applicable.
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shankarh/geode feature/GEODE-240

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #515
    
----
commit bff4e8efa5368fca1a77931ae16e0d94d9e03e53
Author: shankarh <shankarh@apache.org>
Date:   2017-05-16T02:47:05Z

    GEODE-240: Remove deprecated methods on TransactionEvent
    
    Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents
from the TransactionEvent.
    Removed implementation for methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents
from TxEvent and TxRmtEvent.
    Added utility methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents
in TxEventTestUtil.
    Changed tests to use the new utilty methods from TxEventTestUtil.
    
    Signed-off-by: Shankar <shankar@ampool.io>

----


> Remove deprecated methods on TransactionEvent
> ---------------------------------------------
>
>                 Key: GEODE-240
>                 URL: https://issues.apache.org/jira/browse/GEODE-240
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Shankar Hundekar
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The following methods should all be deleted from TransactionEvent and callers should
be changed to instead use getEvents. The caller may have to do its own filtering on getEvents
to find the event(s) it is interested in.
> - getCreateEvents
> - getDestroyEvents
> - getPutEvents
> - getInvalidateEvents
> Some of the existing unit tests depend on the filtering done by these methods so that
filtering will need to move to some test util methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message