geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-234) remove deprecated MirrorType class
Date Mon, 08 May 2017 16:57:05 GMT

    [ https://issues.apache.org/jira/browse/GEODE-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001084#comment-16001084
] 

ASF GitHub Bot commented on GEODE-234:
--------------------------------------

Github user dschneider-pivotal commented on the issue:

    https://github.com/apache/geode/pull/495
  
    The xsd you are looking for is: geode-core/build/resources/main/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
    
    However you should not modify this one since it has already been released.
    The next geode release will be 1.2 so you would want to create a new cache-1.2.xsd and
remove mirror-type from it. Introducing a new xsd involves a bunch of busy work.
    You need to add org.apache.geode.internal.cache.xmlcache.CacheXml.VERSION_1_2,
    update CacheXml.VERSION_LATEST,
    add CacheXml.SCHEMA_1_2_LOCATION,
    add CacheXmlVersion.GEODE_1_2,
    add CacheXmlGeode12DUnitTest that extends CacheXmlGeode10DUnitTest.
    I'm not sure what should be done about these dunit tests. They test the old xsd/dtds which
still do support mirror-type. If we remove support for the mirror-type attribute from the
xml parser code then all these old dtds and xsds will no longer support  mirror-type in their
xml even though the old dtd/xsd says it does. I think all the old dtds we still support also
have data-policy so even with that old dtd you could convert the mirror-type attribute to
data-policy in you existing xml.


> remove deprecated MirrorType class
> ----------------------------------
>
>                 Key: GEODE-234
>                 URL: https://issues.apache.org/jira/browse/GEODE-234
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Avinash Dongre
>
> All uses of MirrorType should be changed to use DataPolicy.REPLICATE.
> All apis that take it as a parameter or return it need to be deleted.
> The cache-9.0.xsd should also be changed to no longer have the "mirror-type" region-attribute.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message