geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dihardman <...@git.apache.org>
Subject [GitHub] geode pull request #544: GEODE-2994 Take backups when region ops are quiesce...
Date Wed, 31 May 2017 18:36:19 GMT
Github user dihardman commented on a diff in the pull request:

    https://github.com/apache/geode/pull/544#discussion_r119438727
  
    --- Diff: geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
    @@ -38,6 +38,15 @@ Do not try to create backup files from a running system by using your
operating
     **Preparing to Make a Backup**
     
     -   Consider compacting your disk store before making a backup. If auto-compaction is
turned off, you may want to do a manual compaction to save on the quantity of data copied
over the network by the backup. For more information on configuring a manual compaction, see
[Manual Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
    +-   Take the backup when region operations are quiescent,
    +to avoid the possibility of an inconsistency between region data and
    +an asyncronous event queue (AEQ),
    +if that backup were to be used to restore a system.
    --- End diff --
    
    I recommend taking out the clause "if that backup were to be used to restore a system".
The explanation that follows fully explains this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message