geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emily Yeh <e...@pivotal.io>
Subject Re: Review Request 59642: GEODE-3000: do not have jetty log at debug level
Date Wed, 31 May 2017 18:22:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/#review176493
-----------------------------------------------------------




geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
Lines 55-59 (patched)
<https://reviews.apache.org/r/59642/#comment249848>

    Perhaps the Scanner should be closed? Just adding `scanner.close()` after the while loop
should do it. (Alternatively, scanner could be instantiated before the `for` loop, so that
it doesn't have to be re-instantiated during every iteration.)


- Emily Yeh


On May 31, 2017, 5:45 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59642/
> -----------------------------------------------------------
> 
> (Updated May 31, 2017, 5:45 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3000: do not have jetty log at debug level
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/resources/log4j2.xml cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59642/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message