geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdxrunner <...@git.apache.org>
Subject [GitHub] geode pull request #549: GEODE-2203: gfsh status locator/server - Command no...
Date Wed, 31 May 2017 17:20:17 GMT
Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/549#discussion_r119419356
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
    @@ -771,11 +771,19 @@ public Result statusLocator(
                   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, LOCATOR_TERM_NAME));
             }
           } else {
    -        final LocatorLauncher locatorLauncher =
    -            new LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
    -                .setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
    -                .setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
    -
    +        final LocatorLauncher locatorLauncher;
    +
    +        if ((locatorHost == null) && (locatorPort == null) && (workingDirectory
== null)
    +            && (pid == null)) {
    +          return ResultBuilder.createShellClientErrorResult(
    +              String.format(CliStrings.STATUS_LOCATOR__NO_LOCATOR_SPECIFIED_ERROR_MESSAGE,
    +                  getLocatorId(locatorHost, locatorPort),
    +                  StringUtils.defaultIfBlank(workingDirectory, SystemUtils.CURRENT_DIRECTORY)));
    --- End diff --
    
    I thought that the simplification of this argument (don't need the defaultIfBlank call)
was in a previous commit, but it seems to have been reverted in your latest commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message