geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaredjstewart <...@git.apache.org>
Subject [GitHub] geode pull request #549: GEODE-2203: gfsh status locator/server - Command no...
Date Tue, 30 May 2017 21:31:20 GMT
Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/549#discussion_r119219867
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
    @@ -771,11 +771,18 @@ public Result statusLocator(
                   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, LOCATOR_TERM_NAME));
             }
           } else {
    -        final LocatorLauncher locatorLauncher =
    -            new LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
    -                .setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
    -                .setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
    +        final LocatorLauncher locatorLauncher;
     
    +        if ((locatorHost == null) && (locatorPort == null) && (workingDirectory
== null)) {
    --- End diff --
    
    What if `locatorPort` is specified, but `locatorHost` is not?  It seems like that might
pass this check, but still result in an error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message