geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrel Schneider <dschnei...@pivotal.io>
Subject Re: Review Request 59404: GEODE-2939: make sure event tracker is initiated from the GII provider
Date Thu, 25 May 2017 23:17:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59404/#review176146
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java
Line 203 (original), 207 (patched)
<https://reviews.apache.org/r/59404/#comment249484>

    You need this map to be thread safe because concurrent puts can happen as you process
multiple replies concurrently.
    
    You can wrap it in either Collections.synchronizedMap or you can make it a ConcurrentHashMap.
    
    Also you could make this line less verbose by just using "<>" on the new side (I
think).


- Darrel Schneider


On May 24, 2017, 5:51 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59404/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 5:51 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn Gallinat.
> 
> 
> Bugs: GEODE-2939
>     https://issues.apache.org/jira/browse/GEODE-2939
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Event tracker initilization for bucket region is delayed until after GII, and will be
initialized from the GII provider.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java 886d678

>   geode-core/src/main/java/org/apache/geode/internal/cache/CacheDistributionAdvisee.java
e4a7957 
>   geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java
c1d1e77 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 485835b

>   geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java 2c86aed

>   geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
fb5f0cf 
>   geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java
3faf41f 
> 
> 
> Diff: https://reviews.apache.org/r/59404/diff/4/
> 
> 
> Testing
> -------
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message