geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Galen O'Sullivan <gosulli...@pivotal.io>
Subject Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start
Date Thu, 25 May 2017 17:52:28 GMT


> On May 25, 2017, 5:51 p.m., Galen O'Sullivan wrote:
> > geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
> > Lines 346 (patched)
> > <https://reviews.apache.org/r/59546/diff/1/?file=1732164#file1732164line346>
> >
> >     Could this be split into two tests, one of which continues and the other of
which triggers a failure later on?

That is, could one of the tests test what happens when we try to evaluate the host later?
(See my question in the overall review comment about whether we ever give up).


- Galen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59546/#review176020
-----------------------------------------------------------


On May 25, 2017, 5:12 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59546/
> -----------------------------------------------------------
> 
> (Updated May 25, 2017, 5:12 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> We configure locator list to start the cache. This locator list is validated while creating
the cache. We verify whether locator host exist or not. Now we have remove this verification
as in cloud environment host may not available for time being. 
> 
> Patch from Bruce. Modified couple of tests.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java
c1bfc93 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
01c6157 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
7caad3f 
>   geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
5ab1bed 
>   geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
1dc2fd1 
>   geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
dc73f04 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
9f6c5fb 
>   geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 9cff80d

>   geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
d6d5d7c 
> 
> 
> Diff: https://reviews.apache.org/r/59546/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message