geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udo Kohlmeyer <ukohlme...@gmail.com>
Subject Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start
Date Wed, 24 May 2017 23:06:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59546/#review176013
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
Lines 234 (patched)
<https://reviews.apache.org/r/59546/#comment249355>

    we seem to assume here that `this.host != null`... the same cannot be said for the `getHost()`
method


- Udo Kohlmeyer


On May 24, 2017, 10:30 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59546/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 10:30 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Patch from Bruce. Modified couple of tests.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java
c1bfc93 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
01c6157 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
7caad3f 
>   geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
5ab1bed 
>   geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
1dc2fd1 
>   geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
dc73f04 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
9f6c5fb 
>   geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 9cff80d

>   geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
d6d5d7c 
> 
> 
> Diff: https://reviews.apache.org/r/59546/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message