-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59492/#review175885
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java
Line 98 (original), 104 (patched)
<https://reviews.apache.org/r/59492/#comment249225>
once all your commands extends this abstract class, these don't need to be static at all.
I would keep them as object methods.
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java
Line 120 (original), 126 (patched)
<https://reviews.apache.org/r/59492/#comment249226>
same here
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
Lines 46 (patched)
<https://reviews.apache.org/r/59492/#comment249224>
I believe all these new commands needs to extends AbstractCommandSupport which implements
CommandMarker. The parser scans this interface implementers to do parsing work.
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java
Lines 43 (patched)
<https://reviews.apache.org/r/59492/#comment249229>
extend the abstract class
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java
Lines 36 (patched)
<https://reviews.apache.org/r/59492/#comment249228>
extend the abstract class
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java
Lines 42 (patched)
<https://reviews.apache.org/r/59492/#comment249227>
you can extends AbstractCommandSupport to get the method you need.
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java
Lines 40 (patched)
<https://reviews.apache.org/r/59492/#comment249230>
extend the abstract class
- Jinmei Liao
On May 23, 2017, 9:54 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59492/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 9:54 p.m.)
>
>
> Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Extract several commands out of LauncherLifecycleCommands into their distinct own classes.
> - Extract some utility methods from LauncherLifecycleCommands into more appropriate
locations.
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java
27bc098
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
2a1662e
> geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ce66057
> geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 12c5c21
> geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a6d3064
> geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java
18fca98
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java
26b903b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
b6c11c4
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
68d055c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java
PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfiguration.java
PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java
PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java
PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java
PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59492/diff/2/
>
>
> Testing
> -------
>
> Precheckin running
>
>
> Thanks,
>
> Jared Stewart
>
>
|