geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Rhomberg <prhomb...@pivotal.io>
Subject Re: Review Request 59457: GEODE-2959: remove DistributedSystem instance in tearDown
Date Mon, 22 May 2017 18:07:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59457/#review175665
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
Lines 26 (patched)
<https://reviews.apache.org/r/59457/#comment249016>

    Unused import?



geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java
Lines 26 (patched)
<https://reviews.apache.org/r/59457/#comment249019>

    Unused import?


- Patrick Rhomberg


On May 22, 2017, 5:57 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59457/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 5:57 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2959
>     https://issues.apache.org/jira/browse/GEODE-2959
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> CacheXmlParserJUnitTest#testCacheXmlParserWithSimplePool uses InternalDistributedSystem#newInstanceForTesting
to add a mock DistributedSystem to existingSystems. This then causes LocatorLauncherTest to
fail because that test expects existingSystems to contain zero instances.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/DistributedSystem.java 29ebf06724fa28de1abdf5174303dd1849e74164

>   geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
eeb44e7a331c1f10f6a40dd39e8b9143671096ed 
>   geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java
b0f5c8dc39ff557e6a550bf17eb61fdfc594fd64 
> 
> 
> Diff: https://reviews.apache.org/r/59457/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message