geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 59287: GEODE-2420: Enable export logs size estimation and user warning
Date Tue, 16 May 2017 17:19:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59287/#review175123
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
Line 230 (original), 300 (patched)
<https://reviews.apache.org/r/59287/#comment248490>

    It doesn't look like the return values of this method or the method on 319 are ever used
in the product code.  Does it make sense to have these return a boolean rather than void?



geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
Line 241 (original), 319 (patched)
<https://reviews.apache.org/r/59287/#comment248492>

    The `diskSize` parameter in this method looks to be unused.


- Jared Stewart


On May 15, 2017, 10:09 p.m., Ken Howe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59287/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 10:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Adds 'export logs' option, --file-limit-size, to allow user to set
> maximun size of the epxorted logs zip file.
> 
> When size checking is enabled (file-limit-size > 0) then the check
> will also prevent filling up the disk on each member while consolidating
> and filtering the logs.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
41c85d6421c8283163b70f2a560c8e4cbb02f2cc 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
20ec1f5702aea341ace5aa3b103c34cbdce1ae87 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java
8d20dc05c14bf558462893c4dd4cbbc474df4077 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java
0a799f6c85dada2791da57585234fa2e47ef0b3d 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
a02c07f2c28156e097306f4b57174cddeda78845 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
96ac76588662b1de5d5bf41c24ab115d90fc0a85 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java
ec2bcfe8ea876172c6946c43c005659d23d055e0 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
90a92f33247ecec8ee300ecb80a5d8ab27193c94 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
d8f2f2db937fc51ab5f917659e766f338b9ae847 
> 
> 
> Diff: https://reviews.apache.org/r/59287/diff/2/
> 
> 
> Testing
> -------
> 
> Precheckin is in progress - all green so far with only DistributedTest still running
> 
> 
> Thanks,
> 
> Ken Howe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message