geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 59246: GEODE-2876: reset isGfshVM flag to false when tearing down tests using CliCommandTestBase.
Date Mon, 15 May 2017 18:41:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59246/#review174999
-----------------------------------------------------------


Ship it!




Ship It!

- Jared Stewart


On May 12, 2017, 10:12 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59246/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 10:12 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> * tests using CliCommandTestBase will set this flag to true which messes up following
test vms.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java bc4db1660054ba837a4907d1173a254931fef230

>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CliCommandTestBase.java
afdb706c285578f63fdaf459ac4ae59d83ab27e3 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
e41164495e2330ffdbf70bd52dc91bc0ae333830 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java
a5293eb0fa0a2599b837abc76903704a45428111 
> 
> 
> Diff: https://reviews.apache.org/r/59246/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message