geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From metatype <...@git.apache.org>
Subject [GitHub] geode issue #509: GEODE-265: Removing deprecated API from Execution interfac...
Date Thu, 11 May 2017 14:07:55 GMT
Github user metatype commented on the issue:

    https://github.com/apache/geode/pull/509
  
    Thanks for your contribution!
    
    If I'm reading the log correctly, `withArgs(IN args)` was deprecated one month ago.  We
should *not* remove this from the public API until the next major version (e.g. 2.0.0).  In
the future when we deprecate an API it would be helpful to mark *when* it was deprecated to
help track this more explicitly.  Can you remove this from the changeset?
    
    ```
    commit aaef124e3d4d7b46c82ddb4d2af65ee48b73ba53
    Author: Alyssa Kim <micro9110@gmail.com>
    Date:   Sat Apr 15 17:48:00 2017 -0700
    
        GEODE-728: Rename Execution.withArgs to Execution.setArguments
        
         * created setArguments
         * deprecated withArgs
         * implemented setArguments of all Execution implementations in Geode project
         * replaced all of withArgs with setArguments
        
        This closes #457
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message