geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udo Kohlmeyer <ukohlme...@gmail.com>
Subject Re: Review Request 59106: GEODE-2898 A non-responsive SSL client can block a server's "acceptor" thread
Date Tue, 09 May 2017 19:19:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59106/#review174363
-----------------------------------------------------------


Ship it!




Ship It!

- Udo Kohlmeyer


On May 9, 2017, 7:12 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59106/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 7:12 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2898
>     https://issues.apache.org/jira/browse/GEODE-2898
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This moves the SSL handshake from the acceptor thread to the handshake thread and adds
a unit test.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
ed294722db4784f1e9fe895d9f00dd6e4521d5d6 
>   geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java
3597152a25de7c2fdc87dfb9ec0e5613b7ec327c 
> 
> 
> Diff: https://reviews.apache.org/r/59106/diff/1/
> 
> 
> Testing
> -------
> 
> TDD - the test failed with a timeout exception but now passes with the supplied fix.
> precheckin testing is underway
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message