geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 59098: GEODE-2876: add logging to diagnose parser test failure in Jenkins
Date Tue, 09 May 2017 16:02:14 GMT


> On May 9, 2017, 4 p.m., Ken Howe wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
> > Lines 52 (patched)
> > <https://reviews.apache.org/r/59098/diff/1/?file=1711545#file1711545line52>
> >
> >     This is probably OK since the change is presumably temporary, and will be removed
after diagnosing the parsing test failures. However, for style consistentcy I would have added
org.apache.logging.log4j.Logger as an import rather than specifying the full class path in
the declaration.

because it has a name collision with the current java.*.util.Logger. After I removed the other
loggers, this would automatcially be fixed by my IDEA.


- Jinmei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59098/#review174330
-----------------------------------------------------------


On May 9, 2017, 3:32 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59098/
> -----------------------------------------------------------
> 
> (Updated May 9, 2017, 3:32 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-2876: add logging to diagnose test failure
> 
> another try to add parser logs using log4j. I have another set of changes that would
remove the other loggers in GfshParser. For now, they co-exist.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java 20ae0226db45574028311493a07cdfcf9fbfb3f0

> 
> 
> Diff: https://reviews.apache.org/r/59098/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message