geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Smith <dsm...@pivotal.io>
Subject Re: Review Request 59040: when advisor cannot found target nodes for bucket id, should double check if the member is offline
Date Mon, 08 May 2017 17:25:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59040/#review174195
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On May 7, 2017, 5:47 p.m., xiaojian zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59040/
> -----------------------------------------------------------
> 
> (Updated May 7, 2017, 5:47 p.m.)
> 
> 
> Review request for geode, Barry Oglesby and Dan Smith.
> 
> 
> Bugs: GEODE-2824
>     https://issues.apache.org/jira/browse/GEODE-2824
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This is a race condition. When a member is offline (in redundentcopy=0 case), an earlier
check will found that. But if it passed the check, the code will enter a retry loop to ask
advisor to give the target node. Finally the advisor will return an empty list of member.
Then the code will screw up and throw the "No target node found" exception. 
> 
> The fix is: when the empty list is return, double check if target node is offline.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionExecutionNodePruner.java
18700a75d 
> 
> 
> Diff: https://reviews.apache.org/r/59040/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message