geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dschneider-pivotal <...@git.apache.org>
Subject [GitHub] geode issue #495: GEODE-234: Removed deprecated MirrorType class and its usa...
Date Mon, 08 May 2017 16:56:35 GMT
Github user dschneider-pivotal commented on the issue:

    https://github.com/apache/geode/pull/495
  
    The xsd you are looking for is: geode-core/build/resources/main/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
    
    However you should not modify this one since it has already been released.
    The next geode release will be 1.2 so you would want to create a new cache-1.2.xsd and
remove mirror-type from it. Introducing a new xsd involves a bunch of busy work.
    You need to add org.apache.geode.internal.cache.xmlcache.CacheXml.VERSION_1_2,
    update CacheXml.VERSION_LATEST,
    add CacheXml.SCHEMA_1_2_LOCATION,
    add CacheXmlVersion.GEODE_1_2,
    add CacheXmlGeode12DUnitTest that extends CacheXmlGeode10DUnitTest.
    I'm not sure what should be done about these dunit tests. They test the old xsd/dtds which
still do support mirror-type. If we remove support for the mirror-type attribute from the
xml parser code then all these old dtds and xsds will no longer support  mirror-type in their
xml even though the old dtd/xsd says it does. I think all the old dtds we still support also
have data-policy so even with that old dtd you could convert the mirror-type attribute to
data-policy in you existing xml.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message