geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joey McAllister <jmcallis...@pivotal.io>
Subject Re: Review Request 59027: GEODE-1996 Confusing references to "multicast" for locators ports
Date Fri, 05 May 2017 21:22:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59027/#review174052
-----------------------------------------------------------


Fix it, then Ship it!




Fix it, then ship it.


geode-docs/basic_config/config_concepts/distributed_system_member_configuration.html.md.erb
Lines 54 (patched)
<https://reviews.apache.org/r/59027/#comment247157>

    I think this "remote" is still referring to this contextual definition of the word, right?
If so, it should go in quotes, too.



geode-docs/managing/monitor_tune/udp_communication.html.md.erb
Lines 44 (patched)
<https://reviews.apache.org/r/59027/#comment247158>

    hyphenate "flow-control protocol"


- Joey McAllister


On May 5, 2017, 3:49 p.m., Dave Barnes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59027/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 3:49 p.m.)
> 
> 
> Review request for geode, Joey McAllister and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1996 Confusing references to "multicast" for locators ports
> 
> 
> Diffs
> -----
> 
>   geode-docs/basic_config/config_concepts/distributed_system_member_configuration.html.md.erb
a06a8c81cd12260f7384a202a4a0d5643806a367 
>   geode-docs/configuring/running/firewalls_ports.html.md.erb 11e4554887cbc845b881ad61959d2a4345bb0c8a

>   geode-docs/managing/monitor_tune/multicast_communication_runtime_considerations.html.md.erb
77fd42b9c043b613c8dcf68feda0bd49d482cd1a 
>   geode-docs/managing/monitor_tune/socket_communication_ephemeral_tcp_port_limits.html.md.erb
3df570a3859f1b49874f682b9639e642584666c2 
>   geode-docs/managing/monitor_tune/socket_communication_have_enough_sockets.html.md.erb
a075e08533e74ae986db9efde552c392cd5cce2c 
>   geode-docs/managing/monitor_tune/socket_communication_setting_socket_buffer_sizes.html.md.erb
41884a2ecc21f607a91eb8910b001be77aa1ad6a 
>   geode-docs/managing/monitor_tune/socket_communication_tcpip_p2p_handshake_timeouts.html.md.erb
486c337092382f9bde702e677ba1122583cff440 
>   geode-docs/managing/monitor_tune/sockets_and_gateways.html.md.erb ca20bf81dbccaad1beaa52b064db1e1644de86e6

>   geode-docs/managing/monitor_tune/udp_communication.html.md.erb 4a5d3c0bf8f24275a4040e8f0f1926a06e990b7f

>   geode-docs/reference/statistics/statistics_list.html.md.erb 7f7b76f79e944ffc495f8974712b1c53b9863a55

>   geode-docs/tools_modules/gfsh/command-pages/connect.html.md.erb c83d2ffe92c7784b5f41b63e879a3199a26ee88a

> 
> 
> Diff: https://reviews.apache.org/r/59027/diff/1/
> 
> 
> Testing
> -------
> 
> Corrected two references to the locator's "multicast port" as described in the JIRA ticket.
Searched the entire user guide, found no other occurrences. In the process, corrected some
typos and formatting issues, which are included in this checkin to save the overhead of creating
a separate ticket and review cycle.
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message