geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From upthewaterspout <...@git.apache.org>
Subject [GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...
Date Mon, 01 May 2017 17:28:12 GMT
Github user upthewaterspout commented on a diff in the pull request:

    https://github.com/apache/geode/pull/481#discussion_r114158872
  
    --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
---
    @@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
         // create PR fileAndChunkRegion, but not to create its buckets for now
         final String fileRegionName = createFileRegionName();
         PartitionAttributes partitionAttributes = dataRegion.getPartitionAttributes();
    -
    -
    -    // create PR chunkRegion, but not to create its buckets for now
    -
    -    // we will create RegionDirectories on the fly when data comes in
    -    HeterogeneousLuceneSerializer mapper = new HeterogeneousLuceneSerializer(getFieldNames());
    -    PartitionedRepositoryManager partitionedRepositoryManager =
    -        new PartitionedRepositoryManager(this, mapper);
         DM dm = this.cache.getInternalDistributedSystem().getDistributionManager();
         LuceneBucketListener lucenePrimaryBucketListener =
    -        new LuceneBucketListener(partitionedRepositoryManager, dm);
    +        new LuceneBucketListener((PartitionedRepositoryManager) partitionedRepositoryManager,
dm);
    --- End diff --
    
    Having to cast is a bit of a bad smell here. It seems like either LuceneBucketListener
should take an AbstractPartitionedRepositoryManager, or createLuceneListenersAndFileChunkRegions
should have been passed in a PartitionRespositoryManager.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message