Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2ABA8200C65 for ; Sat, 15 Apr 2017 03:50:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2909C160BA3; Sat, 15 Apr 2017 01:50:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 96816160B8C for ; Sat, 15 Apr 2017 03:50:03 +0200 (CEST) Received: (qmail 68567 invoked by uid 500); 15 Apr 2017 01:50:02 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 68556 invoked by uid 99); 15 Apr 2017 01:50:02 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Apr 2017 01:50:02 +0000 Received: from mail-qt0-f178.google.com (mail-qt0-f178.google.com [209.85.216.178]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 6EAF21A00A6 for ; Sat, 15 Apr 2017 01:50:02 +0000 (UTC) Received: by mail-qt0-f178.google.com with SMTP id g60so7517504qtd.3 for ; Fri, 14 Apr 2017 18:50:02 -0700 (PDT) X-Gm-Message-State: AN3rC/7m7z/MAq/0YpMe2jPqVGwmmH6Bi614gIl4q0N6YfNAXI7hrPtW XbQ3uKTkqJNW9IcpMdMEbcIkpt2O46SP X-Received: by 10.200.40.72 with SMTP id 8mr333224qtr.204.1492221001684; Fri, 14 Apr 2017 18:50:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.41.76 with HTTP; Fri, 14 Apr 2017 18:50:01 -0700 (PDT) From: Kirk Lund Date: Fri, 14 Apr 2017 18:50:01 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Conditional bug in LocalRegion.concurrencyConfigurationCheck To: geode Content-Type: multipart/alternative; boundary=001a11410c64bb82a9054d2ac64b archived-at: Sat, 15 Apr 2017 01:50:04 -0000 --001a11410c64bb82a9054d2ac64b Content-Type: text/plain; charset=UTF-8 I can't quite make out what the conditional is actually supposed to be checking in the second half but it definitely looks wrong to me. Anyone familiar with this method or what it's supposed to be doing? private void concurrencyConfigurationCheck(VersionTag tag) { // TODO: double negative in next line must be a bug if (!this.concurrencyMessageIssued && *((tag != null) != this.concurrencyChecksEnabled)*) { this.concurrencyMessageIssued = true; logger.info(LocalizedMessage.create( LocalizedStrings.LocalRegion_SERVER_HAS_CONCURRENCY_CHECKS_ENABLED_0_BUT_CLIENT_HAS_1_FOR_REGION_2, new Object[] {!this.concurrencyChecksEnabled, this.concurrencyChecksEnabled, this})); } } --001a11410c64bb82a9054d2ac64b--