Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 48B89200C69 for ; Sat, 22 Apr 2017 02:12:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 472F5160BAF; Sat, 22 Apr 2017 00:12:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8DE2D160B97 for ; Sat, 22 Apr 2017 02:12:21 +0200 (CEST) Received: (qmail 1219 invoked by uid 500); 22 Apr 2017 00:12:20 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 1204 invoked by uid 99); 22 Apr 2017 00:12:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Apr 2017 00:12:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 25FD3C06FD; Sat, 22 Apr 2017 00:12:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0aP0xTicrXLU; Sat, 22 Apr 2017 00:12:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 44EF55F245; Sat, 22 Apr 2017 00:12:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A049EE0436; Sat, 22 Apr 2017 00:12:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 769D7C400D6; Sat, 22 Apr 2017 00:12:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6086367056399180314==" MIME-Version: 1.0 Subject: Review Request 58638: close OffHeapEvictor when cache is closed From: Darrel Schneider To: anilkumar gingade , Lynn Gallinat , Eric Shu Cc: geode , Darrel Schneider Date: Sat, 22 Apr 2017 00:12:17 -0000 Message-ID: <20170422001217.23979.42524@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Darrel Schneider X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58638/ X-Sender: Darrel Schneider Reply-To: Darrel Schneider X-ReviewRequest-Repository: geode archived-at: Sat, 22 Apr 2017 00:12:22 -0000 --===============6086367056399180314== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58638/ ----------------------------------------------------------- Review request for geode, anilkumar gingade, Eric Shu, and Lynn Gallinat. Bugs: GEODE-2811 https://issues.apache.org/jira/browse/GEODE-2811 Repository: geode Description ------- OffHeapEvictor was never closed resulting in a thread leak Diffs ----- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 56243e1b544f5958204e64c2ca391003aa1fd098 geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapEvictor.java b22bb0ec5fa5938a23bad015cf02b9295631bfed geode-core/src/test/java/org/apache/geode/internal/cache/GemFireCacheImplTest.java 6838e748f112d05363185b7a7e28dd4ce08f80c9 Diff: https://reviews.apache.org/r/58638/diff/1/ Testing ------- precheckin Thanks, Darrel Schneider --===============6086367056399180314==--